fix: CondaEnvFileSpec lose the rule object to create new IOFile object #1373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello !
This PR is a bugfix for the bug that broke the tests for snakemake-wrappers like this one snakemake/snakemake-wrappers#449.
The implementation with
CondaEnvFileSpec
seems to lose the rule object needed to create new IOFile object.I am not sure but my bugfix may lead to memory leak.
Another solution is to pass the rule object when the
apply_wildcards
is called.Cheers
Dimitri
QC
docs/
) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).